Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate config to datacheck files #1341

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Propagate config to datacheck files #1341

merged 1 commit into from
Jan 23, 2025

Conversation

moralejo
Copy link
Collaborator

Keep in the attrs of the cosmics table of the dl1 datacheck files the configuration of the analysis.
We will need at least the cleaning levels to interpret the checks, since e.g. the intensity values depend on them

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.48%. Comparing base (035f60f) to head (3bfbd1b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lstchain/datachecks/dl1_checker.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1341   +/-   ##
=======================================
  Coverage   73.47%   73.48%           
=======================================
  Files         134      134           
  Lines       14223    14227    +4     
=======================================
+ Hits        10451    10454    +3     
- Misses       3772     3773    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moralejo moralejo marked this pull request as ready for review January 23, 2025 19:22
@moralejo moralejo requested a review from rlopezcoto January 23, 2025 19:23
@rlopezcoto rlopezcoto merged commit 51b1027 into main Jan 23, 2025
8 checks passed
@rlopezcoto rlopezcoto deleted the config-to-dl1check branch January 23, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants