Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-26] Create delete function for removing files and folders #353

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

brian2w
Copy link
Contributor

@brian2w brian2w commented May 11, 2023

Why the changes are required?

Currently, there is no way to delete files and folders in the CMS.

Changes

  • Added delete file button to sidebar
  • Added delete confirmation modal
  • Opening a folder is now a double click (rather than a single click)
  • Single click 'selects' the folder (indicator still needed) - temporary indicator makes folder red when selected (sorry for the unaesthetic colour atm)

Screenshots

image
image

Comments

  • Need to contact backend team regarding recursively deleting contents inside a folder

@brian2w brian2w requested review from lauraw0 and jamest0 as code owners May 11, 2023 02:09
Copy link
Contributor

@lauraw0 lauraw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! :D We'll ignore the changes in whitespace for now (creating a prettier template is on my todo list somewhere) but if you could make these small ux changes that would be awesomeee:

  • when the user clicks away from the folders and files (onBlur) the selectedFile should revert to null
  • when the user presses on the delete button on the keyboard (onKeyPress) the same delete functionality should apply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants