Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(start): better mobile responsiveness + remove clipping #328

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(start): better mobile responsiveness + remove clipping #328

wants to merge 3 commits into from
+40 −15

Conversation

JamesyJi
Copy link
Contributor

@JamesyJi JamesyJi commented Feb 4, 2023

The main issue was with the ConnectView page overflowing due to no responsiveness on the icons. This was a problem because the way we animate smoothly between the pages is by transformX 100% and so one page overflowing results in issues for the other pages

Welcome

Screen Shot 2023-02-04 at 10 33 08 pm

Connect

Screen Shot 2023-02-04 at 10 33 23 pm

Advice

Screen Shot 2023-02-04 at 10 33 55 pm

Enrolment

Screen Shot 2023-02-04 at 10 34 13 pm

Events

Yes this one is a bit doomed but we'll make another PR for that
Screen Shot 2023-02-04 at 10 34 38 pm

lhjt
lhjt requested changes Feb 4, 2023
View reviewed changes
Copy link
Member

@lhjt lhjt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Can you resolve this issue as well thanks (as in the button being clipped and I believe it also just stays there when you scroll)

image
The discord logo is also clipped

@lhjt lhjt changed the title Fixed Responsiveness Clipping on Mobile fix(start): better mobile responsiveness + remove clipping Feb 4, 2023
@JamesyJi
Copy link
Contributor Author

JamesyJi commented Feb 4, 2023

#328 (review)

@lhjt
Button Issue
Screen Shot 2023-02-05 at 2 52 45 am

Clipping Issue
Screen Shot 2023-02-05 at 2 52 25 am

lhjt
lhjt requested changes Feb 4, 2023
View reviewed changes
Copy link
Member

@lhjt lhjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust the padding of the website icon so that it isn't directly touching the border of the webpage. Try and make it consistent (it's on the left on desktop, but right on mobile?) when hovering over it, the size increases to large and awkwardly such that it is clipped by the border of the page.

@JamesyJi
Copy link
Contributor Author

JamesyJi commented Feb 6, 2023

Adjust the padding of the website icon so that it isn't directly touching the border of the webpage. Try and make it consistent (it's on the left on desktop, but right on mobile?) when hovering over it, the size increases to large and awkwardly such that it is clipped by the border of the page.

I think this is part of the overall website, not the start section so we can make another PR for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhjt lhjt lhjt requested changes

@fafnirZ fafnirZ Awaiting requested review from fafnirZ

@lauraw0 lauraw0 Awaiting requested review from lauraw0

@jamest0 jamest0 Awaiting requested review from jamest0

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesyJi @lhjt