-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(start): better mobile responsiveness + remove clipping #328
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lhjt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjust the padding of the website icon so that it isn't directly touching the border of the webpage. Try and make it consistent (it's on the left on desktop, but right on mobile?) when hovering over it, the size increases to large and awkwardly such that it is clipped by the border of the page.
I think this is part of the overall website, not the start section so we can make another PR for that |
The main issue was with the ConnectView page overflowing due to no responsiveness on the icons. This was a problem because the way we animate smoothly between the pages is by transformX 100% and so one page overflowing results in issues for the other pages
Welcome
Connect
Advice
Enrolment
Events
Yes this one is a bit doomed but we'll make another PR for that