Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Patch] Change UUID to Type #98

Closed
wants to merge 3 commits into from
Closed

[Patch] Change UUID to Type #98

wants to merge 3 commits into from

Conversation

sp4ce-cowboy
Copy link
Contributor

Summary

  • Currently UUID is used to differentiate between entities' components
  • This patch follows the Storage type enum, ensures that a specific component of an entity can be accessed directly

@sp4ce-cowboy sp4ce-cowboy added the bug Something isn't working label Apr 9, 2024
@sp4ce-cowboy sp4ce-cowboy changed the title [Patch] Change UUID to Entity Type [Patch] Change UUID to Type Apr 9, 2024
Vanessamae23
Vanessamae23 reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@Vanessamae23 Vanessamae23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it better if we use T.type as the key?

@sp4ce-cowboy sp4ce-cowboy reopened this Apr 9, 2024
@sp4ce-cowboy
Copy link
Contributor Author

Closing this PR due to re-prioritization of tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vanessamae23 Vanessamae23 Vanessamae23 left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sp4ce-cowboy @Vanessamae23