Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start synching #88

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Conversation

Vanessamae23
Copy link
Contributor

Add start synching and add the RoomState field in the firebase to keep track of the different state of the game player

Closes #86

@Vanessamae23 Vanessamae23 added the bug Something isn't working label Apr 7, 2024
@Vanessamae23 Vanessamae23 self-assigned this Apr 7, 2024
zheng-ze
zheng-ze previously approved these changes Apr 9, 2024
Copy link
Contributor

@zheng-ze zheng-ze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vanessamae23 Vanessamae23 requested review from zheng-ze and removed request for sp4ce-cowboy and keith-gan April 9, 2024 03:44
Copy link
Contributor

@zheng-ze zheng-ze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vanessamae23 Vanessamae23 merged commit 94aaa42 into cs3217-2324:main Apr 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No synchronised start when starting a networked game
2 participants