Add game Mode #46
Merged
Add game Mode #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Vanessamae23
commented
Mar 27, 2024
Vanessamae23
commented
- Event handler added
- A few game entities added
- Death match mode
- Capture the flag mode
added 15 commits
March 27, 2024 00:28
zheng-ze
previously approved these changes
Mar 28, 2024
Comment on lines
30
to
42
| func outOfBound() -> Bool { | ||
| guard let playerComponent = entity?.component(ofType: PlayerComponent.self) else { | ||
| return false | ||
| } | ||
| if playerComponent.player == .ownPlayer && self.position.x > UIScreen.main.bounds.maxX { | ||
| // TODO : Change UIScreen | ||
| return true | ||
| } else if playerComponent.player == .oppositePlayer && self.position.x < UIScreen.main.bounds.minX { | ||
| return true | ||
| } | ||
| return false | ||
| } | ||
|
|
There was a problem hiding this comment.
I think it will be better for this to be in some system?
|
Changes made based on review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.