Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add discrete GameEngine #42

Merged
merged 7 commits into from
Mar 25, 2024
Merged

Add discrete GameEngine #42

merged 7 commits into from
Mar 25, 2024

Conversation

sp4ce-cowboy
Copy link
Contributor

@sp4ce-cowboy sp4ce-cowboy commented Mar 25, 2024 •
edited
Loading

Summary

  • GameEngine extracted out from GameWorld
  • GameEngine essentially encapsulates all the managers and encapsulates game updates.
  • GameWorld remains conforming to Renderable, but GameEngine updated to conform to EventTarget

Fixes

  • Removed almost all SwiftLint errors (removed empty test cases)
  • Fixed some styling issues here and there

@sp4ce-cowboy sp4ce-cowboy self-assigned this Mar 25, 2024
@sp4ce-cowboy sp4ce-cowboy linked an issue Mar 25, 2024 that may be closed by this pull request
Add GameEngine #43
Closed
zheng-ze
zheng-ze approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@zheng-ze zheng-ze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zheng-ze zheng-ze merged commit 2c3e7e3 into cs3217-2324:main Mar 25, 2024
1 check passed
Vanessamae23 pushed a commit to Vanessamae23/group-project-tower-forge that referenced this pull request Mar 30, 2024
@zheng-ze
Merge pull request cs3217-2324#42 from sp4ce-cowboy/feature/branch-ga…
2fa7465 
…meEngine

Add discrete GameEngine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zheng-ze zheng-ze zheng-ze approved these changes

Assignees

@sp4ce-cowboy sp4ce-cowboy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GameEngine
2 participants
@sp4ce-cowboy @zheng-ze