Add Renderer and attempt to generalise UnitGenerator #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne update to systems manager and event manager.
# Conflicts: # TowerForge/TowerForge.xcodeproj/project.pbxproj # TowerForge/TowerForge/GameScene.swift # TowerForge/TowerForge/GameViewController.swift
Vanessamae23
previously approved these changes
Mar 21, 2024
TowerForge/TowerForge/LevelManager/Components/GameComponents/DamageComponent.swift
Outdated
Show resolved
Hide resolved
Vanessamae23
approved these changes
Mar 22, 2024
| @@ -47,6 +47,22 @@ extension GameViewController: SceneUpdateDelegate { | |||
| func update(deltaTime: TimeInterval) { | |||
| gameWorld?.update(deltaTime: deltaTime) | |||
| } | |||
|
|
|||
| func contactBegin(between nodeA: TFAnimatableNode, and nodeB: TFAnimatableNode) { | |||
There was a problem hiding this comment.
I was thinking if we couldjust generalise it to the TFSpriteNode instead of AnimatableNode? and also changing from contactBegin to contactDidBegin
There was a problem hiding this comment.
Yep sure ill change it in my next pr.
|
|
||
| func handleSeparation(between idA: UUID, and idB: UUID) { |
There was a problem hiding this comment.
Is there a need to implement this? since we don't have a separation logic if the units come into contact with each other but perhaps for future powerups this can be a good one.
| @@ -10,4 +10,6 @@ import Foundation | |||
| protocol SceneUpdateDelegate: AnyObject { | |||
| func update(deltaTime: TimeInterval) | |||
| func touch(at location: CGPoint) | |||
| func contactBegin(between nodeA: TFAnimatableNode, and nodeB: TFAnimatableNode) | |||
There was a problem hiding this comment.
same as above, perhaps changing TFAnimatableNode to TFSpriteNode?
Vanessamae23
pushed a commit
to Vanessamae23/group-project-tower-forge
that referenced
this pull request
Mar 30, 2024
Add Renderer and attempt to generalise UnitGenerator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10