Add Systems Component #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TFEntity contains TFComponent as a Dictionary. Change this to a Set to implicitly ensure that each entity only has one instance of any given type of component at any point.
zheng-ze
reviewed
Mar 21, 2024
| } | ||
|
|
||
| movementComponent.updatePosition(with: displacement) | ||
| } | ||
|
|
There was a problem hiding this comment.
I think we need an general update for movement system to generate all the move events. As there is currrently no way for the movement events to be created. Also this serves us the opportunity to control the movement of the entities as well. For example, if 2 entities that can collide with each other are waking towards each other, we need to somehow be able to prevent them from passing each other.
There was a problem hiding this comment.
I'm not sure what you mean by general update movement. Are you saying that move events should be created inside the movement system? What exactly would trigger move events and how would the system handle this?
TowerForge/TowerForge/LevelManager/Events/Implemented Events/SpawnEvent.swift
Show resolved
Hide resolved
TowerForge/TowerForge/LevelManager/Components/TFComponent.swift
Outdated
Show resolved
Hide resolved
TowerForge/TowerForge/LevelManager/Events/Implemented Events/SpawnEvent.swift
Show resolved
Hide resolved
Vanessamae23
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary