Final fixes #124
Merged
Final fixes #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vanessamae23
previously approved these changes
Apr 21, 2024
| @@ -30,7 +36,10 @@ class RankingEngine: InferenceEngine, InferenceDataDelegate { | |||
| } | |||
|
|
|||
| var currentKd: Double { | |||
There was a problem hiding this comment.
Perhaps this can be more clear as to what kd means but just a nitpick
| @@ -52,4 +52,23 @@ final class TotalGamesStatistic: Statistic { | |||
| self.init(permanentValue: value, currentValue: current, maxCurrentValue: max) | |||
| } | |||
|
|
|||
| func merge<T: Statistic>(with that: T) -> T? { | |||
There was a problem hiding this comment.
this function has multiple repetition
There was a problem hiding this comment.
Yes, initially I tried to have a default implementation within Statistics, however, StatisticsDatabase is unable to use the merge function when done that way due to some incompatibility with the (any Statistic.Type) Metatype or something. This is the most robust workaround I found.
TowerForge/TowerForge/Metrics/Statistics/StatisticsEngine.swift
Outdated
Show resolved
Hide resolved
TowerForge/TowerForge/ViewControllers/PlayerStatsViewController.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Various bug fixes, optimizations, and improvements. Primarily restructuring Storage to support Firebase's async ops. Also update the player stats page.
Completed
Pending