Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Player UI #119

Merged
merged 15 commits into from
Apr 20, 2024
Merged

Conversation

sp4ce-cowboy
Copy link
Contributor

@sp4ce-cowboy sp4ce-cowboy commented Apr 18, 2024

Summary

  • Added Achievements, Missions, Rank UI in a Player Stats UI page.
  • Also added permanent lightmode override, and appicon
image image

Pending (the below will be moved to a new PR, this PR wil be reserved for UI only)

  • Storage Architecture to be updated to support more than just StatisticsDatabase (i.e. Storage Database)
  • Proof-of-concept implementation of dual conflict resolution for storage (code exists already but no way to demo)
    • For e.g. StatisticsDatabase will use MERGE and CharacterDatabase will use KEEP_LATEST simultaneously
  • Restructure Storage to be instance based instead of passing StatisticsDatabase around
  • GameInfo return to display upon end of game about what achievements/missions completed

@sp4ce-cowboy sp4ce-cowboy marked this pull request as ready for review April 20, 2024 12:21
@sp4ce-cowboy sp4ce-cowboy changed the title [Feature] Metrics + Storage + UI Final [Feature] Add Player UI Apr 20, 2024
@sp4ce-cowboy sp4ce-cowboy requested a review from zheng-ze April 20, 2024 12:36
zheng-ze
zheng-ze previously approved these changes Apr 20, 2024
Copy link
Contributor

@zheng-ze zheng-ze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Comment on lines 19 to 26
if segue.identifier == "showPlayerStats" {
// Get the new view controller using segue.destination.
// Pass the selected object to the new view controller.
if let playerStatsVC = segue.destination as? PlayerStatsViewController {
// Set any properties of playerStatsVC here
// For example, pass an AchievementsDatabase instance if needed
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't seem to be doing anything here. Accidental commit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIxed, thanks.

@sp4ce-cowboy sp4ce-cowboy requested a review from zheng-ze April 20, 2024 14:07
@sp4ce-cowboy sp4ce-cowboy merged commit 96cf306 into cs3217-2324:main Apr 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants