Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all scenes and views to be responsive except for GameScene #103

Merged
merged 5 commits into from
Apr 10, 2024

Conversation

zheng-ze
Copy link
Contributor

@zheng-ze zheng-ze commented Apr 9, 2024

Update all storyboards to scale with different iPads and fix bug where multiplayer was broken since player and gameroom not being passed to GameViewController

@zheng-ze zheng-ze self-assigned this Apr 9, 2024
Vanessamae23
Vanessamae23 previously approved these changes Apr 10, 2024
Copy link
Contributor

@Vanessamae23 Vanessamae23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Vanessamae23
Vanessamae23 previously approved these changes Apr 10, 2024
Copy link
Contributor

@Vanessamae23 Vanessamae23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Vanessamae23 Vanessamae23 self-requested a review April 10, 2024 02:32
Copy link
Contributor

@Vanessamae23 Vanessamae23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Vanessamae23 Vanessamae23 merged commit e641776 into cs3217-2324:main Apr 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants