Refactor MI parsing to decrease the number of regex matches to perform #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md
Summary of changes
The previous code to match MI records used to do matches twice. This PR simplifies the code (hopefully!) and means that matches need to happen only once.
Functionally, there should be no changes as I kept the regexes mostly identical and the same checks are executed in the same order.
“Mostly” because tokens used to be matched with
(\d*)
and are now matched with(\d+)?
which I think makes it clearer to readers of the code that tokens are optional.Test plan
Tested by running