Fix travis #20
Open
Fix travis #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clone zeromq from git Build with cmake
Download ameba Comment out running ameba for now Speed up libzmq building
|
Seems to be a couple different errors in the spec
|
The example in the README doesn't actually work, it would just deadlock Made an explicit basic example to run and updated README The change was to remove the loop
bcardiff
added a commit
that referenced
this pull request
Sep 16, 2023
bcardiff
added a commit
that referenced
this pull request
Sep 16, 2023
Same finding as #20 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cleaned up the travis.yml ( simplified ).
libzmq is cloned and built with cmake now.
The error currently breaking travis is that the shared library could not be found, which I addressed by installing zeromq to a location where crystal spec can find it.
That being said, this crystal binding should be built with the static lib to remove that problem entirely.
Also, now that travis can run, crystal spec will timeout on a test.