-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: require gas in ica precompile is higher than consumed #1237
Conversation
Important Auto Review SkippedDraft detected. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the TipsChat with CodeRabbit Bot (
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1237 +/- ##
===========================================
+ Coverage 16.67% 48.13% +31.45%
===========================================
Files 79 74 -5
Lines 5786 6197 +411
===========================================
+ Hits 965 2983 +2018
+ Misses 4743 2896 -1847
- Partials 78 318 +240 |
Update CHANGELOG.md Signed-off-by: mmsqe <[email protected]> fix query
1a28139
to
b7ace17
Compare
return 0 | ||
} | ||
if method == QueryAccountMethodName { | ||
baseCost = uint64(len(input)) * ic.kvGasConfig.ReadCostPerByte |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)