Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: solomachine and ibc-go are outdated #1089

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Problem: solomachine and ibc-go are outdated #1089

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
193edba
Problem: solomachine and ibc-go are outdated
mmsqe Oct 16, 2024
aaf1dec
Update integration_tests/install_solo_machine.nix
mmsqe Oct 16, 2024
6ccc6bd
fix ci
mmsqe Oct 16, 2024
3f4187a
Revert "fix ci"
mmsqe Oct 16, 2024
355827e
try v4
mmsqe Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/audit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: true
persist-credentials: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just follow the error message, previous ci was failed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/actions/checkout#usage
the doc suggests it defaults to true, maybe try to upgrade to v4?

- name: install govulncheck
run: go install -v golang.org/x/vuln/cmd/[email protected]
- name: govuln sec scan
Expand Down
12 changes: 12 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,14 @@ jobs:
if: github.event_name == 'issue_comment'
with:
submodules: true
persist-credentials: true
token: ${{ secrets.GITHUB_TOKEN }}
ref: ${{ steps.pr_data.outputs.ref }}
- name: Normal check out code
uses: actions/checkout@v3
with:
submodules: true
persist-credentials: true
if: github.event_name == 'push' || github.event_name == 'pull_request'
- id: changed-files
uses: tj-actions/changed-files@v41
Expand Down Expand Up @@ -151,6 +153,8 @@ jobs:
security-events: write
steps:
- uses: actions/checkout@v3
with:
persist-credentials: true
- uses: cachix/install-nix-action@v23
with:
nix_path: nixpkgs=channel:nixos-22.11
Expand Down Expand Up @@ -217,13 +221,15 @@ jobs:
if: github.event_name == 'issue_comment'
with:
submodules: true
persist-credentials: true
token: ${{ secrets.GITHUB_TOKEN }}
ref: ${{ needs.build.outputs.ref }}
- name: Normal check out code
uses: actions/checkout@v3
if: github.event_name == 'push' || github.event_name == 'pull_request'
with:
submodules: true
persist-credentials: true
- id: changed-files
uses: tj-actions/changed-files@v41
with:
Expand Down Expand Up @@ -263,13 +269,15 @@ jobs:
if: github.event_name == 'issue_comment'
with:
submodules: true
persist-credentials: true
token: ${{ secrets.GITHUB_TOKEN }}
ref: ${{ needs.build.outputs.ref }}
- name: Normal check out code
uses: actions/checkout@v3
if: github.event_name == 'push' || github.event_name == 'pull_request'
with:
submodules: true
persist-credentials: true
- id: changed-files
uses: tj-actions/changed-files@v41
with:
Expand Down Expand Up @@ -309,13 +317,15 @@ jobs:
if: github.event_name == 'issue_comment'
with:
submodules: true
persist-credentials: true
token: ${{ secrets.GITHUB_TOKEN }}
ref: ${{ needs.build.outputs.ref }}
- name: Normal check out code
uses: actions/checkout@v3
if: github.event_name == 'push' || github.event_name == 'pull_request'
with:
submodules: true
persist-credentials: true
- id: changed-files
uses: tj-actions/changed-files@v41
with:
Expand Down Expand Up @@ -412,6 +422,8 @@ jobs:
if: github.event_name == 'push' || github.event_name == 'pull_request'
steps:
- uses: actions/checkout@v3
with:
persist-credentials: true
- id: changed-files
uses: tj-actions/changed-files@v41
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/buildwin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
uses: actions/checkout@v3
with:
submodules: true
persist-credentials: true
- name: Set GOBIN
run: |
echo "$(go env GOPATH)/bin" >> $GITHUB_PATH
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: true
persist-credentials: true
- id: changed-files
uses: tj-actions/changed-files@v41
with:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v3
with:
persist-credentials: true
- uses: actions/setup-go@v3
with:
go-version: 1.22
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/gosec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ jobs:
GO111MODULE: on
steps:
- uses: actions/checkout@v3
with:
persist-credentials: true
- id: changed-files
uses: tj-actions/changed-files@v41
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: true
persist-credentials: true
- id: changed-files
uses: tj-actions/changed-files@v41
with:
Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/nix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: true
persist-credentials: true
- uses: cachix/install-nix-action@v23
with:
extra_nix_config: |
Expand All @@ -40,6 +41,7 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: true
persist-credentials: true
- uses: cachix/install-nix-action@v23
with:
extra_nix_config: |
Expand Down Expand Up @@ -83,6 +85,7 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: true
persist-credentials: true
- uses: cachix/install-nix-action@v23
with:
extra_nix_config: |
Expand All @@ -104,6 +107,7 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: true
persist-credentials: true
- uses: cachix/install-nix-action@v23
with:
extra_nix_config: |
Expand Down Expand Up @@ -139,6 +143,7 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: true
persist-credentials: true
- uses: cachix/install-nix-action@v23
with:
extra_nix_config: |
Expand Down Expand Up @@ -174,6 +179,7 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: true
persist-credentials: true
- uses: cachix/install-nix-action@v23
with:
extra_nix_config: |
Expand Down Expand Up @@ -209,6 +215,7 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: true
persist-credentials: true
- uses: cachix/install-nix-action@v23
with:
extra_nix_config: |
Expand Down Expand Up @@ -244,6 +251,7 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: true
persist-credentials: true
- uses: cachix/install-nix-action@v23
with:
extra_nix_config: |
Expand Down Expand Up @@ -279,6 +287,7 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: true
persist-credentials: true
- uses: cachix/install-nix-action@v23
with:
extra_nix_config: |
Expand Down Expand Up @@ -314,6 +323,7 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: true
persist-credentials: true
- uses: cachix/install-nix-action@v23
with:
extra_nix_config: |
Expand Down Expand Up @@ -350,6 +360,7 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: true
persist-credentials: true
- uses: cachix/install-nix-action@v23
with:
extra_nix_config: |
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ jobs:
environment: release
steps:
- uses: actions/checkout@v3
with:
persist-credentials: true
- uses: cachix/install-nix-action@v23
with:
nix_path: nixpkgs=channel:nixos-22.11
Expand Down Expand Up @@ -57,6 +59,8 @@ jobs:
environment: release
steps:
- uses: actions/checkout@v3
with:
persist-credentials: true
- uses: cachix/install-nix-action@v23
with:
nix_path: nixpkgs=channel:nixos-22.11
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/semgrep.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: true
persist-credentials: true
# Run the "semgrep ci" command on the command line of the docker image.
- run: semgrep ci
env:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/staticmajor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ jobs:
steps:
- name: Check out repository code
uses: actions/checkout@v3
with:
persist-credentials: true
- name: Staticmajor action
id: staticmajor
uses: orijtech/staticmajor-action@main
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
- [#1084](https://github.com/crypto-org-chain/chain-main/pull/1084) Add MsgModuleQuerySafe in allowed messages for ica host param.
- [#1086](https://github.com/crypto-org-chain/chain-main/pull/1086) Upgrade ibc-go to `v8.4.0`.
- [#1087](https://github.com/crypto-org-chain/chain-main/pull/1087) Ensure expedited related gov params pass the basic validation.
- [#1088](https://github.com/crypto-org-chain/chain-main/pull/1088) Upgrade solomachine to `v0.1.4` and ibc-go to `v8.5.1`.

*Dec 6, 2023*

Expand Down
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ require (
github.com/cosmos/cosmos-db v1.0.3-0.20240408151834-e75f6e4b28d8
github.com/cosmos/cosmos-sdk v0.50.9
github.com/cosmos/gogoproto v1.7.0
github.com/cosmos/ibc-go/modules/capability v1.0.0
github.com/cosmos/ibc-go/v8 v8.4.0
github.com/cosmos/ibc-go/modules/capability v1.0.1
github.com/cosmos/ibc-go/v8 v8.5.1
github.com/cosmos/rosetta v0.50.3-1
github.com/crypto-org-chain/cronos/store v0.0.5-0.20240716081818-7f581a697f6d
github.com/crypto-org-chain/cronos/versiondb v0.0.0-20240716081818-7f581a697f6d
Expand Down
8 changes: 4 additions & 4 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,10 +429,10 @@ github.com/cosmos/gogoproto v1.7.0 h1:79USr0oyXAbxg3rspGh/m4SWNyoz/GLaAh0QlCe2fr
github.com/cosmos/gogoproto v1.7.0/go.mod h1:yWChEv5IUEYURQasfyBW5ffkMHR/90hiHgbNgrtp4j0=
github.com/cosmos/iavl v1.1.2 h1:zL9FK7C4L/P4IF1Dm5fIwz0WXCnn7Bp1M2FxH0ayM7Y=
github.com/cosmos/iavl v1.1.2/go.mod h1:jLeUvm6bGT1YutCaL2fIar/8vGUE8cPZvh/gXEWDaDM=
github.com/cosmos/ibc-go/modules/capability v1.0.0 h1:r/l++byFtn7jHYa09zlAdSeevo8ci1mVZNO9+V0xsLE=
github.com/cosmos/ibc-go/modules/capability v1.0.0/go.mod h1:D81ZxzjZAe0ZO5ambnvn1qedsFQ8lOwtqicG6liLBco=
github.com/cosmos/ibc-go/v8 v8.4.0 h1:K2PfX0AZ+1XKZytHGEMuSjQXG/MZshPb83RSTQt2+cE=
github.com/cosmos/ibc-go/v8 v8.4.0/go.mod h1:zh6x1osR0hNvEcFrC/lhGD08sMfQmr9wHVvZ/mRWMCs=
github.com/cosmos/ibc-go/modules/capability v1.0.1 h1:ibwhrpJ3SftEEZRxCRkH0fQZ9svjthrX2+oXdZvzgGI=
github.com/cosmos/ibc-go/modules/capability v1.0.1/go.mod h1:rquyOV262nGJplkumH+/LeYs04P3eV8oB7ZM4Ygqk4E=
github.com/cosmos/ibc-go/v8 v8.5.1 h1:3JleEMKBjRKa3FeTKt4fjg22za/qygLBo7mDkoYTNBs=
github.com/cosmos/ibc-go/v8 v8.5.1/go.mod h1:P5hkAvq0Qbg0h18uLxDVA9q1kOJ0l36htMsskiNwXbo=
github.com/cosmos/ics23/go v0.11.0 h1:jk5skjT0TqX5e5QJbEnwXIS2yI2vnmLOgpQPeM5RtnU=
github.com/cosmos/ics23/go v0.11.0/go.mod h1:A8OjxPE67hHST4Icw94hOxxFEJMBG031xIGF/JHNIY0=
github.com/cosmos/keyring v1.2.0 h1:8C1lBP9xhImmIabyXW4c3vFjjLiBdGCmfLUfeZlV1Yo=
Expand Down
8 changes: 4 additions & 4 deletions gomod2nix.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,11 +170,11 @@ schema = 3
version = "v1.1.2"
hash = "sha256-fhh5fN1BMDxbF4PobERMQdIb9vIrxaSl0tRXas0WKmc="
[mod."github.com/cosmos/ibc-go/modules/capability"]
version = "v1.0.0"
hash = "sha256-xOeHJWUj6fTc2EUGiE4dgfY2WkvrqTg/FWewoUvQcvg="
version = "v1.0.1"
hash = "sha256-iRhj2WTr99DgAl80h25pxtkO6iHYjyHflwpxKKG5b6E="
[mod."github.com/cosmos/ibc-go/v8"]
version = "v8.4.0"
hash = "sha256-c4EWR/F23cRc+mwdIZsjrxwyELGf82jKXfdUtxJIjSA="
version = "v8.5.1"
hash = "sha256-F4VZbKo1n9fLSxLSR+/ZaisbJ2v+EHjpXVpCovGTiyQ="
[mod."github.com/cosmos/ics23/go"]
version = "v0.11.0"
hash = "sha256-mgU/pqp4kASmW/bP0z6PzssfjRp7GU9ioyvNlDdGC+E="
Expand Down
8 changes: 4 additions & 4 deletions integration_tests/install_solo_machine.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
{ stdenv, fetchurl, lib }:
let
version = "v0.1.3";
version = "v0.1.4";
srcUrl = {
x86_64-linux = {
url =
"https://github.com/crypto-com/ibc-solo-machine/releases/download/${version}/ubuntu-latest-${version}.tar.gz";
sha256 = "sha256-Ui92r8J0I3jWGUvaI83rf9PMNyBW4yfnq98lcJ+1fkg=";
sha256 = "sha256-wQix7ZeYTVD+yIWGr4F+XXnHbvXe2WZeNxG2lIDtmJ4=";
};
x86_64-darwin = {
url =
"https://github.com/crypto-com/ibc-solo-machine/releases/download/${version}/macos-latest-${version}.tar.gz";
sha256 = "sha256-zx4342stMYzgQDXAKwnZKSfdLynGIApOFKZ+CjRCyaE=";
sha256 = "sha256-NYmm44l5exQiG9DbwUM/UZiEmxc0JriXM8/l/xpc+q4=";
};
aarch64-darwin = {
url =
"https://github.com/crypto-com/ibc-solo-machine/releases/download/${version}/macos-latest-${version}.tar.gz";
sha256 = "sha256-vVgsng5jpmKRODUvjDja/dTvysXSg14O0oVqRswlFts=";
sha256 = "sha256-NYmm44l5exQiG9DbwUM/UZiEmxc0JriXM8/l/xpc+q4=";
};
}.${stdenv.system} or (throw
"Unsupported system: ${stdenv.system}");
Expand Down
Loading