Miscellaneous minor bug fixes (#353)

* Use fullName instead of shortName for courses TTD has asked us to use fullNames of courses instead of shortNames as they only put in course IDs in shortName, hence the change was necessary * Add pptx mimeType to render PPT drawable for pptx files * Remove bottom constraint in forum attachment row This change was made to keep consistency with the textView which is also not constrained to the barrier below
crux-bphc · Feb 24, 2024 · b849ebf · b849ebf
1 parent 1f52507
commit b849ebf
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/app/src/main/java/crux/bphc/cms/models/course/Course.kt b/app/src/main/java/crux/bphc/cms/models/course/Course.kt
@@ -31,7 +31,7 @@ open class Course(
     @Ignore var courseName: Array<String> = emptyArray() // The entire courseName
         get() {
             if (_courseName == null) {
-                val courseName = shortName
+                val courseName = fullName
                 // Specifies the string pattern which is to be searched
                 val pattern = Pattern.compile(NAME_REGEX, Pattern.MULTILINE)
                 val matcher = pattern.matcher(courseName)

diff --git a/app/src/main/java/crux/bphc/cms/utils/FileUtils.kt b/app/src/main/java/crux/bphc/cms/utils/FileUtils.kt
@@ -10,7 +10,7 @@ object FileUtils {
             "application/pdf" -> R.drawable.file_pdf
             "application/vnd.ms-excel", "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet" -> R.drawable.file_excel
             "application/msword", "application/vnd.openxmlformats-officedocument.wordprocessingml.document" -> R.drawable.file_word
-            "application/vnd.ms-powerpoint", "application/vnd.openxmlformats-officedocument.presentationml.template", "application/vnd.openxmlformats-officedocument.presentationml.slideshow", "application/vnd.oasis.opendocument.presentation" -> R.drawable.file_powerpoint
+            "application/vnd.ms-powerpoint", "application/vnd.openxmlformats-officedocument.presentationml.presentation", "application/vnd.openxmlformats-officedocument.presentationml.template", "application/vnd.openxmlformats-officedocument.presentationml.slideshow", "application/vnd.oasis.opendocument.presentation" -> R.drawable.file_powerpoint
             else -> R.drawable.ic_document_unknown_type
         }
     }

diff --git a/app/src/main/res/layout/row_attachment_detail_forum.xml b/app/src/main/res/layout/row_attachment_detail_forum.xml
@@ -34,8 +34,7 @@
 
         app:layout_constraintStart_toEndOf="@id/name"
         app:layout_constraintEnd_toStartOf="@+id/more"
-        app:layout_constraintTop_toTopOf="parent"
-        app:layout_constraintBottom_toBottomOf="@id/barrier"/>
+        app:layout_constraintTop_toTopOf="parent" />
 
     <View
         android:id="@+id/click_wrapper"