forked from denoland/deno
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(info): resolve workspace member mappings (denoland#26350)
This PR fixes the issue where mapped specifiers in a workspace member would never be found. Only mapped paths from the workspace root would resolve. This was caused by always passing the workspace root url to the import map resolver instead of the workspace member one. Fixes denoland#26138 Fixes denoland/fresh#2615 --------- Signed-off-by: Marvin Hagemeister <[email protected]> Co-authored-by: David Sherret <[email protected]>
- Loading branch information
1 parent
d047cab
commit 0e60bb9
Showing
8 changed files
with
57 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
{ | ||
"args": "info preact/debug", | ||
"output": "with_import_map.out", | ||
"exitCode": 0 | ||
"steps": [ | ||
{ | ||
"args": "info preact/debug", | ||
"output": "with_import_map.out", | ||
"exitCode": 0 | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
{ | ||
"tests": { | ||
"member_folder": { | ||
"args": "info --quiet foo", | ||
"cwd": "member", | ||
"output": "info_workspace_member.out", | ||
"exitCode": 0 | ||
}, | ||
"member_folder_sub": { | ||
"args": "info --quiet foo", | ||
"cwd": "member/sub", | ||
"output": "info_workspace_member_sub.out", | ||
"exitCode": 0 | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"workspace": ["./member"] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
local: [WILDCARD]file.ts | ||
type: TypeScript | ||
dependencies: 0 unique | ||
size: [WILDCARD] | ||
|
||
file://[WILDCARD]/member/sub/file.ts ([WILDCARD]) |
6 changes: 6 additions & 0 deletions
6
tests/specs/info/workspace_member/info_workspace_member_sub.out
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
local: [WILDCARD]file.ts | ||
type: TypeScript | ||
dependencies: 0 unique | ||
size: [WILDCARD] | ||
|
||
file://[WILDCARD]/member/sub/file.ts ([WILDCARD]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"imports": { | ||
"foo": "./sub/file.ts" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export {}; |