fix(crowdsec): Prevent empty annotation error for cert manifests

[holysoles]

Problem

When using a values file like the following (taken from this crowdsec blog post):

container_runtime: containerd
tls:
  enabled: true
  bouncer:
    reflector:
      namespaces: ["traefik"]
agent:
  # Specify each pod whose logs you want to process
  acquisition:
    - namespace: traefik
      podName: traefik-*
      program: traefik
  env:
    - name: PARSERS
      value: "crowdsecurity/cri-logs"
    - name: COLLECTIONS
      value: "crowdsecurity/traefik"
    - name: DISABLE_PARSERS
      value: "crowdsecurity/whitelists"
  persistentVolume:
    config:
      enabled: false
lapi:
  dashboard:
    enabled: false
    ingress:
      host: my-crowdsec.lan
      enabled: true
  persistentVolume:
    config:
      enabled: false
  env:
    - name: DISABLE_ONLINE_API
      value: "true"

The following error is observed:

Could not determine release state: unable to determine cluster state: Certificate/crowdsec/crowdsec-agent dry-run failed (Invalid): Certificate.cert-manager.io "crowdsec-agent" is invalid: spec.secretTemplate.annotations: Invalid value: "null": spec.secretTemplate.annotations in body must be of type object: "null"

This is because the annotations key is set empty in the
agent-certificate and bouncer-certificate resource files.

Proposed Solution

Implement similar logic that exists in the lapi-certificate template file, meaning only add the annotations key if we'll be populating it.

[github-actions]

@holysoles: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

• /kind feature
• /kind enhancement
• /kind fix
• /kind chore
• /kind dependencies

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the forked project rr404/oss-governance-bot repository.

[github-actions]

@holysoles: There are no area labels on this PR. You can add as many areas as you see fit.

• /area agent
• /area local-api
• /area cscli
• /area security
• /area configuration

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the forked project rr404/oss-governance-bot repository.

[holysoles]

/area configuration

[holysoles]

/kind fix