Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the closeOnScroll option. #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrismeyers
Copy link

This option prevents the gallery from closing upon scrolling. When this option is set to false, background scrolling is disabled until the gallery is closed.

This feature was primarily implemented to allow zooming/panning on mobile. When coupled with some overriding CSS like this:

.fullscreen-v-img {
  touch-action: pinch-zoom pan-x !important;
}

you'll be able to zoom and pan without the gallery closing.

This option prevents the gallery from closing upon scrolling. When
this option is set to false, background scrolling is disabled until
the gallery is closed.
@fahrenq
Copy link
Contributor

fahrenq commented Jan 10, 2019

Hi @chrismeyers, thank you very much for the contribution!
Unfortunately, I'm unavailable to work on the project now.

@anandkulkarni
Maybe it's possible for you to allocate some developers for this project? People are making contributions and it would be cool to at least merge changes (and probably write tests, so merging changes would be less painful in future).

Thanks.

@filipaalvesd
Copy link

filipaalvesd commented Jul 1, 2019

Hi @crowdbotics-apps,

Could you please let us know when this PR is merged or when this functionality is integrated? It is really useful to disable this option if we want.

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants