Update based on fixes made in the websockets/ws package #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for contributing! unfortunately, this hard codes the protocol to msgpack when the user specifies subprotocols. also, what is the issue being addressed with this change .. this #550 ? |
|
Exactly, this error. I thought it was interesting to keep the parameter optional and so I put a default value. When the "protocol" is not specified, the error is displayed, precisely because the validation was changed. Of course, I believe that at other points where a "join" is used will need to change, as the ws package is accepting "array" and not "string". |
|
We currently limit the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust based on fix made in websockets/ws. In this commit: websockets/ws@0aecf0c#diff-44c2c0628f273ea1ab6dbb7c1fa81a1765d8adf9fbdd083e2a3b93d8d1cb5f61