Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manipulating values other than JSON #155

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Conversation

marcospassos
Copy link
Member

@marcospassos marcospassos commented Jan 9, 2025

Summary

The current implementation of the JSON pointer is limited to manipulating JSON values, even though the underlying logic can handle any data type.

This PR refactors the typings to accept any value as input while ensuring the retrieval operations remain type-safe and aligned with the input structure. As a result, when types are defined correctly, the retrieved values will be constrained to the types present in the source input.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@marcospassos marcospassos added the feature New feature label Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

👋 @marcospassos

Thanks for your contribution!

The approval and merge process is almost fully automated 🧙

Here's how it works:

  1. You open a new pull request
  2. Automated tests check the code
  3. Maintainers review the code
  4. Once approved, the PR is ready to merge.

👉 Omit the extended description
Please remove the commit body before merging the pull request.
Instead, include the pull request number in the title to provide the full context
about the change.

☝️ Lastly, the title for the commit will come from the pull request title. So please provide a descriptive title that summarizes the changes in 50 characters or less using the imperative mood.

Happy coding! 🎉

@marcospassos marcospassos merged commit 81475be into master Jan 9, 2025
9 checks passed
@marcospassos marcospassos deleted the widen-input-type branch January 9, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant