Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a defaut while miss cache provider #115

Merged
merged 11 commits into from
May 16, 2024

Conversation

renan628
Copy link
Member

@renan628 renan628 commented May 7, 2024

Summary

This PR implements a new DefaultWhileMiss cache provider, that gets values from an inner cache, or returns a default value if a configured time limit is exceeded.

Related to:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@renan628 renan628 added the feature New feature label May 7, 2024
@renan628 renan628 requested review from Fryuni and denis-rossati May 7, 2024 18:52
@renan628 renan628 self-assigned this May 7, 2024
src/defaultWhileMiss.ts Outdated Show resolved Hide resolved
@renan628 renan628 requested a review from Fryuni May 8, 2024 19:11
[skip ci]
src/defaultWhileMiss.ts Outdated Show resolved Hide resolved
test/defaultWhileMiss.test.ts Outdated Show resolved Hide resolved
test/defaultWhileMiss.test.ts Outdated Show resolved Hide resolved
test/defaultWhileMiss.test.ts Outdated Show resolved Hide resolved
test/defaultWhileMiss.test.ts Outdated Show resolved Hide resolved
test/defaultWhileMiss.test.ts Outdated Show resolved Hide resolved
test/defaultWhileMiss.test.ts Outdated Show resolved Hide resolved
test/defaultWhileMiss.test.ts Outdated Show resolved Hide resolved
src/defaultWhileMiss.ts Outdated Show resolved Hide resolved
@renan628 renan628 requested a review from marcospassos May 14, 2024 21:36
@Fryuni Fryuni merged commit 6955e71 into master May 16, 2024
6 checks passed
@Fryuni Fryuni deleted the implement-defaut-while-miss branch May 16, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create DefaultWhileMissCacheProvider cache
4 participants