Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADDED: [Feature] GitHub Repository Tracking #106

Closed
wants to merge 7 commits into from

Conversation

IamMQaisar
Copy link
Contributor

@IamMQaisar IamMQaisar commented Apr 3, 2024

Fixes

Fixes #99 by @Darylgolden

Description

Added github_scratcher.py to now track the total number of repositories on GitHub that utilize Creative Commons licenses of all types.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@IamMQaisar IamMQaisar requested review from a team as code owners April 3, 2024 22:21
@IamMQaisar IamMQaisar requested review from annatuma and Shafiya-Heena and removed request for a team April 3, 2024 22:21
@Darylgolden
Copy link
Contributor

Hey @IamMQaisar, I'm not sure if you missed it but I've already started working on a PR fixing this at #101. Sorry that it's taking a while for me to respond to the reviews as I'm busy with other things IRL.

@IamMQaisar
Copy link
Contributor Author

IamMQaisar commented Apr 4, 2024

Hi @Darylgolden ,
Yes Brother, I know that you are working on the PR and this PR of mine was just to fast track and ommit the errors as well as to correlate with the latest changes of the codebase mergers.

You may eventually bring out the changes of files, from my PR to your and make your PR better/complete so that @TimidRobot has ease in merging the PR rather than us being waiting that he mentions all the changes themselve and then we make those changes. Which will only delay the process and make the maintainer go through and mention everything manually.

@Darylgolden
Copy link
Contributor

I understand, but I think it would have been better if you had made a PR to my branch if you wanted to help fix the issues in my PR. Creating a competing PR makes the attribution of changes unclear and feels like it creates a sense of competition rather than collaboration, even if that was not your intention. Also, for a open source project, I don't think a 3 day wait from a review is that long to necessitate superseding another PR. I would have understood if it was stale for a week or longer.

@TimidRobot TimidRobot self-assigned this Apr 4, 2024
@TimidRobot TimidRobot added the ⛔️ status: discarded Will not be worked on label Apr 4, 2024
@TimidRobot
Copy link
Member

I understand, but I think it would have been better if you had made a PR to my branch if you wanted to help fix the issues in my PR. Creating a competing PR makes the attribution of changes unclear and feels like it creates a sense of competition rather than collaboration, even if that was not your intention. Also, for a open source project, I don't think a 3 day wait from a review is that long to necessitate superseding another PR. I would have understood if it was stale for a week or longer.

Agreed.

@TimidRobot TimidRobot closed this Apr 4, 2024
@IamMQaisar
Copy link
Contributor Author

Sure, I'll take that into account and make it more collaborative next time by doing a PR into the existing PR of others.

@IamMQaisar
Copy link
Contributor Author

I understand, but I think it would have been better if you had made a PR to my branch if you wanted to help fix the issues in my PR.

I am unable to fork your repo, as it's probably not enabled to be forked. Can you enable it so that I can fork and work on it?

@Darylgolden
Copy link
Contributor

@IamMQaisar I believe it's enabled by default. What problems do you get when you attempt to fork?

@IamMQaisar
Copy link
Contributor Author

Let me show you in a while.

@IamMQaisar
Copy link
Contributor Author

image

@IamMQaisar IamMQaisar deleted the github_scratcher branch April 8, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛔️ status: discarded Will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] GitHub repository tracking
3 participants