Add support to publish cfr as a binary using PyInstaller #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
==========================================
+ Coverage 72.01% 81.76% +9.74%
==========================================
Files 79 79
Lines 3209 3213 +4
==========================================
+ Hits 2311 2627 +316
+ Misses 898 586 -312
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
amotl
force-pushed
the
s/cfr-binary
branch
3 times, most recently
from
8b7b6b7 to
addaeec
Compare
amotl
force-pushed
the
s/cfr-binary
branch
4 times, most recently
from
bc6336c to
3b5f012
Compare
|
Hi again. I've added a basic CI/GHA workflow definition with 7fb9df3, and reported about the outcome on the tracking ticket. Building upon this, we can think about other build- and publishing-destinations/-procedures/-cycles on behalf of subsequent iterations, if you agree with that approach, @seut. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Use PyInstaller to build self-contained application bundles of the CrateDB Cluster Flight Recorder (CFR).
Preview
See section "Artifacts » Produced during runtime" on GHA run #9826830191.