Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution for POI Sums #4321

Merged
merged 12 commits into from
Feb 27, 2024
Merged

Solution for POI Sums #4321

merged 12 commits into from
Feb 27, 2024

Conversation

danielzsh
Copy link
Member

@danielzsh danielzsh commented Feb 17, 2024 •
edited
Loading

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.
Addresses #4165

  • I have tested my code.
  • I have added my solution according to the steps here.
  • I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • I have linked this PR to any issues that it closes.

@danielzsh danielzsh marked this pull request as ready for review February 17, 2024 21:39
SansPapyrus683
SansPapyrus683 requested changes Feb 17, 2024
View reviewed changes
Copy link
Contributor

@SansPapyrus683 SansPapyrus683 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ik u said time limit was tight, so just asking here

solutions/gold/poi-sums.mdx Outdated Show resolved Hide resolved
solutions/gold/poi-sums.mdx Outdated Show resolved Hide resolved
solutions/gold/poi-sums.mdx Show resolved Hide resolved
solutions/gold/poi-sums.mdx Outdated Show resolved Hide resolved
SansPapyrus683
SansPapyrus683 reviewed Feb 20, 2024
View reviewed changes
Copy link
Contributor

@SansPapyrus683 SansPapyrus683 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kk
just need proof of ac w/ the updated code

after that @ryanchou-dev can merge whenerver

SansPapyrus683
SansPapyrus683 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@SansPapyrus683 SansPapyrus683 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github stinks

@danielzsh
Copy link
Member Author

since sending submission links doesnt work here's a screenshot
image

@SansPapyrus683
Copy link
Contributor

wth why do you only get 10 seconds

@envyaims
Copy link
Member

wth why do you only get 10 seconds

0.1 seconds

@SansPapyrus683
Copy link
Contributor

i misspoke

@danielzsh
Copy link
Member Author

uhh @envyaims would you mind looking at this since ryan seems to be afk

ryanchou-dev
ryanchou-dev approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@ryanchou-dev ryanchou-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this :D

@ryanchou-dev ryanchou-dev merged commit 0e8c239 into cpinitiative:master Feb 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanchou-dev ryanchou-dev ryanchou-dev approved these changes

@SansPapyrus683 SansPapyrus683 SansPapyrus683 approved these changes

@dongliuu dongliuu Awaiting requested review from dongliuu dongliuu is a code owner

@envyaims envyaims Awaiting requested review from envyaims envyaims is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielzsh @SansPapyrus683 @envyaims @ryanchou-dev