-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSoC 2024- Scaladoc Search in Protosearch #241
Conversation
Fix `scaladoc` sbt project build
Merge changes from 'scaladoc-plugin'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @golden-skipper03 for all your hard work on this!
I think we're getting very close to merge ready. I've left a handful of comments and change requests here, but they're mostly minor things. The bulk of your work here is done and working nicely :)
laikaIO/src/main/resources/pink/cozydev/protosearch/sbt/search.js
Outdated
Show resolved
Hide resolved
scaladoc/src/main/scala/pink/cozydev/protosearch/scaladoc/ParseScaladoc.scala
Outdated
Show resolved
Hide resolved
scaladoc/src/main/scala/pink/cozydev/protosearch/scaladoc/ScaladocIndexer.scala
Outdated
Show resolved
Hide resolved
scaladoc/src/main/scala/pink/cozydev/protosearch/scaladoc/ScaladocSearcher.scala
Outdated
Show resolved
Hide resolved
scaladoc/src/main/scala/pink/cozydev/protosearch/scaladoc/ParseScaladoc.scala
Outdated
Show resolved
Hide resolved
scaladoc/src/main/scala/pink/cozydev/protosearch/scaladoc/ParseScaladoc.scala
Outdated
Show resolved
Hide resolved
scaladoc/src/test/scala/pink/cozydev/protosearch/scaladoc/ScaladocSuite.scala
Show resolved
Hide resolved
scaladoc/src/main/scala/pink/cozydev/protosearch/scaladoc/ScaladocIndexer.scala
Outdated
Show resolved
Hide resolved
I also fixed the error that i got during the checks so it also passed all checks with this commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the changes @golden-skipper03!
I think this is looking good now and we're ready to merge :)
Congrats on finishing up. I am eager to use this. 🎉
This pull request introduces key features to integrate Scaladoc search into Protosearch, making it easier to search through documentation contained within Scala source files.
Key changes-
Visible changes-
Instructions to follow-
projectName/createScaladocIndex
site\target\docs\site\search
directorypython -m http.server
localhost:XXXX/search/search.html?index="indexName"&type=scaladoc