Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoC 2024- Scaladoc Search in Protosearch #241

Merged
merged 31 commits into from
Oct 21, 2024

Conversation

golden-skipper03
Copy link
Contributor

This pull request introduces key features to integrate Scaladoc search into Protosearch, making it easier to search through documentation contained within Scala source files.

Key changes-

  1. Scaladoc parsing- Added functionality to parse Scaladoc comments to extract important information such as function names, descriptions, parameters, type parameters, annotations, implicit parameters.
  2. Scaladoc Indexing- Created a module to index parsed Scaladoc content using existing protosearch indexing data structures so that users can quickly search and retrieve documentation.
  3. UI Changes- Enhanced the user interface to support searching over index.
  4. A new sbt plugin, ProtosearchScaladocPlugin, has been developed by mentor, Andrew Valencik as a convenience to help the construction of indexes using the parsing and indexing module.

Visible changes-

image

Instructions to follow-

  1. Follow contribution tutorial for setting up protosearch.
  2. Inside the project that you have chosen, run this command to create index- projectName/createScaladocIndex
  3. Copy the created index inside site\target\docs\site\search directory
  4. Launch a local webserver from the site directory (e.g. simple-http-server (https://github.com/TheWaWaR/simple-http-server) or python -m http.server
  5. Go to url localhost:XXXX/search/search.html?index="indexName"&type=scaladoc

Copy link
Contributor

@valencik valencik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @golden-skipper03 for all your hard work on this!
I think we're getting very close to merge ready. I've left a handful of comments and change requests here, but they're mostly minor things. The bulk of your work here is done and working nicely :)

@golden-skipper03
Copy link
Contributor Author

I also fixed the error that i got during the checks so it also passed all checks with this commit

Copy link
Contributor

@valencik valencik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the changes @golden-skipper03!

I think this is looking good now and we're ready to merge :)
Congrats on finishing up. I am eager to use this. 🎉

@valencik valencik merged commit f285669 into cozydev-pink:main Oct 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants