Rework the Account model #1999
Draft
Rework the Account model #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenruidigao
force-pushed
the
sg-accounts-rework
branch
from
19ea01a to
7b9a9a5
Compare
|
STEVE anything I can do here? |
Right now, probably not a lot, but thanks for offering! I think that this is probably still not ready and I'm not sure if this is something we should even do. However, I do think that we should consider changing the account model since the way seasons are recorded seems kind of janky right now. I'd be interested to know what your thoughts are, though! PS: I've also been working on a version with updated dependencies and rewriting the server in Typescript and I've found having Typescript makes the code a lot easier to manage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please describe the changes made in the pull request here.
I don't think you want to merge this (since I believe it stil is kind of broken), but it contains some changes to make working with accounts significantly easier (and enables automatic season resets).
I think it also fixes some errors I found in the code while rewriting the accounts model, but those might be hard to find. It also contains the fixes in #1998 (I'm sorry, I know this makes it hard for this PR to be useful).
Screenshots
These are effectively required for non-trivial changes, but appreciated for all.
So ideally the site looks exactly the same, but I almost guarantee you there are some bugs in this PR.
Below you'll find a checklist. For each item on the list, check one option (if completed) and delete the other as appropriate. (Delete this line too)
Tested Locally
Tests
Changelog
Changelog Entry (delete this section if this PR does not need a changelog entry)
Check one, delete the other:
Check one, delete the other:
Changelog Headline: Revamp accounts model. Make seasons automatically reset.
Changelog Details: Many variables in the accounts model have been renamed. Season stats should now automatically reset when the server restarts. Other things to do with seasons might not automatically reset / work when the season resets.