Smiller coti/ct address #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smiller-coti
force-pushed
the
smiller-coti/ctAddress
branch
from
254ba48 to
031b3b0
Compare
gmesika-coti
requested changes
Sep 24, 2024
src/crypto_utils.ts
Outdated
| signature: new Array<Uint8Array> | ||
| } | ||
|
|
||
| for (let i = 0; i < encodedStr.length / 8; i++) { |
There was a problem hiding this comment.
consider changing the loop
src/crypto_utils.ts
Outdated
| functionSelector: string | ||
| ) { | ||
| // consider improving address validation | ||
| if (plaintext.substring(0, 2) !== '0x' || plaintext.length !== 42) { |
There was a problem hiding this comment.
did you consider using
const { utils } = require('ethers')
utils.isAddress(address)
| functionSelector | ||
| ) | ||
|
|
||
| const inputText = { |
There was a problem hiding this comment.
i think we should enhance it to a datatype of some ciphered address to manage the 3 parts away from the user
There was a problem hiding this comment.
Do you mean something like this?
src/crypto_utils.ts
Outdated
| @@ -191,16 +253,40 @@ export function decryptUint(ciphertext: bigint, userKey: string): bigint { | |||
| return decodeUint(decryptedMessage) | |||
| } | |||
|
|
|||
| export function decryptString(ciphertext: Array<bigint>, userKey: string): string { | |||
| let decryptedStr = new Array<number>(ciphertext.length) | |||
| export function decryptString(ciphertext: { value: bigint[] }, userKey: string): string { | |||
There was a problem hiding this comment.
not sure on this code with the #18 changes - we need to review final look
smiller-coti
force-pushed
the
smiller-coti/ctAddress
branch
2 times, most recently
from
4fdc8ea to
50ade23
Compare
gmesika-coti
requested changes
Sep 26, 2024
src/crypto_utils.ts
Outdated
| // We use 8 bytes since we will use ctUint64 to store | ||
| // each chunk of 8 characters | ||
| for (let i = 0; i < encodedStr.length; i += EIGHT_BYTES) { | ||
| const startIdx = i |
There was a problem hiding this comment.
same comment i guess some how it is the same change?
smiller-coti
force-pushed
the
smiller-coti/ctAddress
branch
2 times, most recently
from
968ccda to
e8aac4d
Compare
smiller-coti
force-pushed
the
smiller-coti/ctAddress
branch
from
e8aac4d to
0183765
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.