Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Test Themis with OpenSSL 3.0 #877

Merged
merged 2 commits into from
Nov 22, 2021
Merged

CI: Test Themis with OpenSSL 3.0 #877

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ed5408
CI: Unroll and tweak OpenSSL 3.0 build that should fail
ilammy Nov 10, 2021
5339dc6
CI: Build and test with OpenSSL 3.0 (on macOS only)
ilammy Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion .github/workflows/test-core.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,18 @@ jobs:
- name: Build Themis Core (OpenSSL)
if: always()
run: make prepare_tests_basic ENGINE=openssl BUILD_PATH=build-openssl
- name: Build Themis Core (OpenSSL 3.0)
# TODO: expand this to Linux systems when OpenSSL 3.0 system library is available there
if: ${{ matrix.os == 'macos-latest' }}
run: |
openssl3="$(brew --prefix openssl@3)"
export ENGINE=openssl
export ENGINE_INCLUDE_PATH="$openssl3/include"
export ENGINE_LIB_PATH="$openssl3/lib"
# TODO: stop using deprecated API so that warnings can be errors again
export WITH_EXPERIMENTAL_OPENSSL_3_SUPPORT=yes
export WITH_FATAL_WARNINGS=no
make prepare_tests_basic BUILD_PATH=build-openssl-3.0
- name: Build Themis Core (BoringSSL)
if: always()
run: make prepare_tests_basic ENGINE=boringssl BUILD_PATH=build-boringssl
Expand All @@ -68,6 +80,16 @@ jobs:
- name: Run test suite (OpenSSL)
if: always()
run: make test ENGINE=openssl BUILD_PATH=build-openssl
- name: Run test suite (OpenSSL 3.0)
if: ${{ matrix.os == 'macos-latest' }}
run: |
openssl3="$(brew --prefix openssl@3)"
export ENGINE=openssl
export ENGINE_INCLUDE_PATH="$openssl3/include"
export ENGINE_LIB_PATH="$openssl3/lib"
export WITH_EXPERIMENTAL_OPENSSL_3_SUPPORT=yes
export WITH_FATAL_WARNINGS=no
make test BUILD_PATH=build-openssl-3.0
- name: Run test suite (BoringSSL)
if: always()
run: make test ENGINE=boringssl BUILD_PATH=build-boringssl
Expand All @@ -80,7 +102,10 @@ jobs:
# Themis uses OpenSSL 1.1 by default if installed.
# Explicitly request OpenSSL 3.0 by pointing the build into OpenSSL 3.0's paths.
openssl3=$(brew --prefix openssl@3)
if ! make ENGINE=openssl BUILD_PATH=build-openssl-3.0 ENGINE_INCLUDE_PATH=$openssl3/include ENGINE_LIB_PATH=$openssl3/lib
export ENGINE=openssl
export ENGINE_INCLUDE_PATH="$openssl3/include"
export ENGINE_LIB_PATH="$openssl3/lib"
if ! make BUILD_PATH=build-openssl-3.0-without-magic-word
then
true
else
Expand Down