feat(ics20): initial version of transfer app

.gitignore

@@ -18,3 +18,7 @@ yarn.lock
 !broadcast
 broadcast/*
 broadcast/*/31337/
+
+# ide files
+.idea/
+*.iml

README.md

@@ -27,36 +27,36 @@ Note that OpenZeppelin Contracts is pre-installed, so you can follow that as an
 
 This is a list of the most frequently needed commands.
 
-### Build
+### Install Dependencies
 
-Build the contracts:
+Install the dependencies:
 
 ```sh
-$ forge build
+$ bun install
 ```
 
-### Clean
+### Build
 
-Delete the build artifacts and cache directories:
+Build/compile the contracts:
 
 ```sh
-$ forge clean
+$ forge build
 ```
 
-### Compile
+### Test
 
-Compile the contracts:
+Run the tests:
 
 ```sh
-$ forge build
+$ forge test
 ```
 
-### Coverage
+### Clean
 
-Get a test coverage report:
+Delete the build artifacts and cache directories:
 
 ```sh
-$ forge coverage
+$ forge clean
 ```
 
 ### Deploy
@@ -97,12 +97,12 @@ Lint the contracts:
 $ bun run lint
 ```
 
-### Test
+### Coverage
 
-Run the tests:
+Get a test coverage report:
 
 ```sh
-$ forge test
+$ forge coverage
 ```
 
 Generate test coverage and output result to the terminal:

src/ICS02Client.sol

@@ -35,7 +35,7 @@ contract ICS02Client is IICS02Client, IICS02ClientErrors, Ownable {
     function getCounterparty(string calldata clientId) public view returns (CounterpartyInfo memory) {
         CounterpartyInfo memory counterpartyInfo = counterpartyInfos[clientId];
         if (bytes(counterpartyInfo.clientId).length == 0) {
-            revert IBCClientNotFound(clientId);
+            revert IBCCounterpartyClientNotFound(clientId);
         }
 
         return counterpartyInfo;

src/ICS26Router.sol

@@ -60,7 +60,7 @@ contract ICS26Router is IICS26Router, IBCStore, Ownable, IICS26RouterErrors, Ree
     /// @param msg_ The message for sending packets
     /// @return The sequence number of the packet
     function sendPacket(MsgSendPacket calldata msg_) external nonReentrant returns (uint32) {
-        string memory counterpartyId = ics02Client.getCounterparty(msg_.sourcePort).clientId;
+        string memory counterpartyId = ics02Client.getCounterparty(msg_.sourceChannel).clientId;
 
         // TODO: validate all identifiers
         if (msg_.timeoutTimestamp <= block.timestamp) {
@@ -83,7 +83,11 @@ contract ICS26Router is IICS26Router, IBCStore, Ownable, IICS26RouterErrors, Ree
         IIBCAppCallbacks.OnSendPacketCallback memory sendPacketCallback =
             IIBCAppCallbacks.OnSendPacketCallback({ packet: packet, sender: msg.sender });
 
-        apps[msg_.sourcePort].onSendPacket(sendPacketCallback);
+        IIBCApp app = apps[msg_.sourcePort];
+        if (app == IIBCApp(address(0))) {
+            revert IBCAppNotFound(msg_.sourcePort);
+        }
+        app.onSendPacket(sendPacketCallback);
 
         IBCStore.commitPacket(packet);