feat(ics20): implement on receive packet #20
Conversation
| @@ -40,6 +42,27 @@ func populateQueryReqToPath(ctx context.Context, chain *cosmos.CosmosChain) erro | |||
| return nil | |||
| } | |||
|
|
|||
| func ABCIQuery(ctx context.Context, chain *cosmos.CosmosChain, req *abci.RequestQuery) (*abci.ResponseQuery, error) { | |||
There was a problem hiding this comment.
I added this one as a utility function, mostly for debugging to make sure commitments were really in the store as expected.
The reason I could not reuse the existing generic function was because the method it got from the request was wrong.
There was a problem hiding this comment.
You could use GRPCQuery function below I think
There was a problem hiding this comment.
I tried, but the method/path came out wrong, for some reason. 🤷
| "{\"amount\":\"", | ||
| Strings.toString(amount), | ||
| "\",\"denom\":\"", | ||
| "{\"denom\":\"", |
There was a problem hiding this comment.
These were changed to match the order they come in from ibc-go. This is a limitation of the ICS20Lib: it only supports JSON in a specific order. Parsing the JSON in any order is possible, but might be more gas-intensive. Should we create an issue for that? There is a TODO below on this.
There was a problem hiding this comment.
Yes, let's create an issue. And please link the issues to the todo items (as numbers) if there is an associated issue.
|
@srdtrk, I had already implemented the seconds/nanoseconds checker, so I left it in here. But if you would prefer to remove it, we can revert that and change to only use nanoseconds that are divisible by 1,000,000,000 in the e2e test. |
| @@ -40,6 +42,27 @@ func populateQueryReqToPath(ctx context.Context, chain *cosmos.CosmosChain) erro | |||
| return nil | |||
| } | |||
|
|
|||
| func ABCIQuery(ctx context.Context, chain *cosmos.CosmosChain, req *abci.RequestQuery) (*abci.ResponseQuery, error) { | |||
There was a problem hiding this comment.
You could use GRPCQuery function below I think
No description provided.