imp: added multipass to handle relaying errors gracefully #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
+ Coverage 96.84% 96.88% +0.04%
==========================================
Files 11 12 +1
Lines 539 546 +7
==========================================
+ Hits 522 529 +7
Misses 17 17 ☔ View full report in Codecov by Sentry. |
srdtrk
commented
Dec 4, 2024
Comment on lines
+4
to
23
| import { ICSCore } from "./ICSCore.sol"; | ||
| import { IIBCApp } from "./interfaces/IIBCApp.sol"; | ||
| import { IICS26Router } from "./interfaces/IICS26Router.sol"; | ||
| import { IICS02Client } from "./interfaces/IICS02Client.sol"; | ||
| import { IICS04Channel } from "./interfaces/IICS04Channel.sol"; | ||
| import { ICSCore } from "./ICSCore.sol"; | ||
| import { IIBCStore } from "./interfaces/IIBCStore.sol"; | ||
| import { IICS24HostErrors } from "./errors/IICS24HostErrors.sol"; | ||
| import { IBCStore } from "./utils/IBCStore.sol"; | ||
| import { IICS26RouterErrors } from "./errors/IICS26RouterErrors.sol"; | ||
| import { Ownable } from "@openzeppelin/access/Ownable.sol"; | ||
| import { Strings } from "@openzeppelin/utils/Strings.sol"; | ||
| import { IBCIdentifiers } from "./utils/IBCIdentifiers.sol"; | ||
| import { IIBCAppCallbacks } from "./msgs/IIBCAppCallbacks.sol"; | ||
| import { ICS24Host } from "./utils/ICS24Host.sol"; | ||
| import { ILightClientMsgs } from "./msgs/ILightClientMsgs.sol"; | ||
| import { IICS04ChannelMsgs } from "./msgs/IICS04ChannelMsgs.sol"; | ||
| import { IBCStore } from "./utils/IBCStore.sol"; | ||
| import { ICS24Host } from "./utils/ICS24Host.sol"; | ||
| import { IBCIdentifiers } from "./utils/IBCIdentifiers.sol"; | ||
| import { Multipass } from "./utils/Multipass.sol"; | ||
|
|
||
| import { Ownable } from "@openzeppelin/access/Ownable.sol"; | ||
| import { Strings } from "@openzeppelin/utils/Strings.sol"; | ||
| import { ReentrancyGuardTransient } from "@openzeppelin/utils/ReentrancyGuardTransient.sol"; | ||
| import { Multicall } from "@openzeppelin/utils/Multicall.sol"; |
There was a problem hiding this comment.
I reorganized the deps 😅 . Maybe there is a linter for this?
AdityaSripal
reviewed
Dec 4, 2024
Comment on lines
+11
to
+13
| * Consider any assumption about calldata validation performed by the sender may be violated if it's not especially | ||
| * careful about sending transactions invoking {multipass}. For example, a relay address that filters function | ||
| * selectors won't filter calls nested within a {multipass} operation. |
There was a problem hiding this comment.
What happens when one call fails? Do the state changes of that specific call get reverted while the rest will continue to pass?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #112
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.