Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable parallel test escrow checks using unique denominations #7872

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: enable parallel test escrow checks using unique denominations #7872

wants to merge 1 commit into from

Conversation

VolodymyrBg
Copy link

Description

This PR fixes issue #6742 by introducing unique denominations for each test to avoid state interference when running tests in parallel. The changes enable proper escrow amount verification in parallel test execution.

The solution includes:

  • Adding getUniqueDenom helper to create test-specific denominations
  • Modifying all transfer tests to use unique denominations
  • Re-enabling escrow amount verification in parallel tests
  • Cleaning up test setup and variable declarations

closes: #6742

  • Targeted PR against the correct branch
  • Linked to GitHub issue Enable checks for total escrow in E2Es #6742 with discussion
  • Code follows the module structure standards and Go style guide
  • Wrote unit and integration tests (modified existing e2e tests)
  • No documentation updates needed (test-only changes)
  • Added relevant godoc comments to new helper function
  • Provided conventional commit message
  • No changelog needed (test-only changes)
  • Re-reviewed Files changed in GitHub PR explorer
  • Review SonarCloud Report in comments once CI passes

@VolodymyrBg
fix: enable parallel test escrow checks using unique denominations
255fcb2 
This commit fixes issue cosmos#6742 by introducing unique denominations for each test
to avoid state interference when running tests in parallel. The changes include:

- Add getUniqueDenom helper to create test-specific denominations
- Modify all transfer tests to use unique denominations
- Re-enable escrow amount verification in parallel tests
- Clean up test setup and variable declarations

The solution allows tests to run in parallel while still verifying escrow
functionality, improving test coverage and reliability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@gjermundgaraba gjermundgaraba Awaiting requested review from gjermundgaraba gjermundgaraba is a code owner

@srdtrk srdtrk Awaiting requested review from srdtrk srdtrk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable checks for total escrow in E2Es
1 participant
@VolodymyrBg