Compare Timeout timestamps in seconds instead of nanoseconds #7857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjermundgaraba
approved these changes
Jan 20, 2025
| @@ -53,15 +54,17 @@ func (k *Keeper) sendPacket( | |||
| return 0, "", errorsmod.Wrapf(clienttypes.ErrInvalidHeight, "cannot send packet using client (%s) with zero height", sourceClient) | |||
| } | |||
|
|
|||
| // client timestamps are in nanoseconds while packet timeouts are in seconds | |||
| // thus to compare them, we convert the client timestamp to seconds in uint64 | |||
| // to be consistent with IBC V2 specified timeout behaviour | |||
| latestTimestamp, err := k.ClientKeeper.GetClientTimestampAtHeight(ctx, sourceClient, latestHeight) | |||
There was a problem hiding this comment.
nit: would be slightly easier to read the code below if this was called latestTimestampNano (and would avoid accidental usage later)
| // check that timeout timestamp has passed on the other end | ||
| // client timestamps are in nanoseconds while packet timeouts are in seconds | ||
| // so we convert client timestamp to seconds in uint64 to be consistent | ||
| // with IBC V2 timeout behaviour | ||
| proofTimestamp, err := k.ClientKeeper.GetClientTimestampAtHeight(ctx, packet.SourceClient, proofHeight) |
|
gjermundgaraba
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #7512
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.