New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(testing): Implement Solomachine client and chain upgrade functionality in endpoint.go #7823

Open

crStiv wants to merge 1 commit into cosmos:main from crStiv:todo

crStiv commented Jan 5, 2025

This PR addresses and implements the TODO items in the endpoint.go testing file:

Implemented Solomachine client creation:
- Added full implementation for Solomachine client type
- Properly initialized client state and consensus state
- Integrated with existing client creation flow
Enhanced chain upgrade functionality:
- Implemented proper chain upgrade scheduling mechanism
- Added upgrade height calculation
- Improved state management during upgrades
- Enhanced code organization and documentation

Changes maintain compatibility with existing test infrastructure while providing more complete implementation of previously unimplemented features.

Related issues:

Resolves TODO in CreateClient() for Solomachine implementation
Implements chain upgrade functionality mentioned in test: add UpgradeChain and UpgradeClient endpoint test functions #1169

Testing:

Existing tests continue to pass
Functionality has been manually verified


          Update endpoint.go

8570d86

crStiv requested review from AdityaSripal, gjermundgaraba and srdtrk as code owners

January 5, 2025 22:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

gjermundgaraba Awaiting requested review from gjermundgaraba gjermundgaraba is a code owner

srdtrk Awaiting requested review from srdtrk srdtrk is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet