Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used pixelData to update texture instead of voxelManager to improve memory footprint #1761

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ManojAgiliad
Copy link

@ManojAgiliad ManojAgiliad commented Jan 17, 2025

Context

This changes is done to run the volumeViewport3D example and other example might not work with it.
We have introduced voxelManager to handle the data in cornerstone2.0, but while root causing the increased memory footprint I came across the logic that if we use pixelData directly instead of scalarData from voxelManager the memory consumption is low.

Changes & Results

Instead if creating voxelManager instance I have set it to null.
Used image pixelData instead of scalarData from voxelManager to update the texture.

Testing

I'm using the iPhone13 device for testing and instruments tool present on Mac to log the memory footprint

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

Copy link

stackblitz bot commented Jan 17, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for cornerstone-3d-docs failed. Why did it fail? →

Name Link
🔨 Latest commit f52e8f9
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/678a45cb59640c0008f5e0e7

@ManojAgiliad ManojAgiliad marked this pull request as draft January 17, 2025 11:58
@ManojAgiliad ManojAgiliad marked this pull request as ready for review January 17, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant