Used pixelData to update texture instead of voxelManager to improve memory footprint #1761
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This changes is done to run the volumeViewport3D example and other example might not work with it.
We have introduced voxelManager to handle the data in cornerstone2.0, but while root causing the increased memory footprint I came across the logic that if we use pixelData directly instead of scalarData from voxelManager the memory consumption is low.
Changes & Results
Instead if creating voxelManager instance I have set it to null.
Used image pixelData instead of scalarData from voxelManager to update the texture.
Testing
I'm using the iPhone13 device for testing and instruments tool present on Mac to log the memory footprint
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-api
to update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment