fix: OpenJPH compression issues - temporarily publish debug #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
wayfarer3130
commented
Aug 2, 2024
| @@ -27,8 +27,8 @@ | |||
| "@cornerstonejs/codec-charls": ">=1.2.3", | |||
| "@cornerstonejs/codec-libjpeg-turbo-8bit": ">=1.2.2", | |||
| "@cornerstonejs/codec-little-endian": ">=0.0.6", | |||
| "@cornerstonejs/codec-openjpeg": "^1.2.4", | |||
| "@cornerstonejs/codec-openjph": "^2.4.5", | |||
| "@cornerstonejs/codec-openjpeg": ">=1.2.4", | |||
There was a problem hiding this comment.
This makes it easy to test newer versions as the linking doesn't get messed up.
|
Please merge aous72/OpenJPH#149 after this PR is merged/status checked |
wayfarer3130
commented
Sep 4, 2024
| @@ -1,8 +1,8 @@ | |||
| #!/bin/sh | |||
| mkdir -p build | |||
| mkdir -p dist | |||
| #(cd build && CXXFLAGS=-msimd128 emcmake cmake -DCMAKE_BUILD_TYPE=Debug ..) | |||
| (cd build && CXXFLAGS=-msimd128 emcmake cmake ..) | |||
| (cd build && CXXFLAGS=-msimd128 emcmake cmake -DCMAKE_BUILD_TYPE=Debug ..) | |||
There was a problem hiding this comment.
This is temporary until we figure out why the build is failing
wayfarer3130
commented
Sep 4, 2024
| @@ -38,7 +38,7 @@ class HTJ2KDecoder | |||
| { | |||
| // Use the following for debugging to ensure updated version info | |||
| // Update the XX to check that reload has completed | |||
| // OJPH_INFO(0x00010002, "vXX HTJ2K Decoder"); | |||
| OJPH_INFO(0x00010002, "v06 HTJ2K Decoder"); | |||
There was a problem hiding this comment.
Temporary while we figure out why the code fails to decode
There was a problem hiding this comment.
as talked, this makes it bigger but gives stack trace etc
sedghi
changed the title
sedghi
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to the latest openjph version, and switched the dicom-codec libraries to use >= includes for easy linking of test versions. Seems to improve the HTJ2K stability enormously.