Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing JSON Content-Type rule #253

Merged
merged 1 commit into from
May 10, 2024

Conversation

theseion
Copy link
Contributor

@theseion theseion commented May 9, 2024

The new modsecurity.conf file was missing rule 200001, which enables body processing of application/json.

Also took the opportunity to put the content of the file into a form that is easier to maintain w.r.t. to changes from upstream.

Fixes #252

The new modsecurity.conf file was missing rule 200001, which enables
body processing of `application/json`.

Also took the opportunity to put the content of the file into a form
that is easier to maintain w.r.t. to changes from upstream.

Fixes coreruleset#252
@theseion theseion requested a review from fzipi May 9, 2024 16:51
@fzipi
Copy link
Member

fzipi commented May 9, 2024

Hmmmm.... #239 (comment) ?

@fzipi
Copy link
Member

fzipi commented May 9, 2024

Ok, so both are needed, right?

@theseion
Copy link
Contributor Author

theseion commented May 9, 2024

Yes. One is for application/json, the other one for application/<something>+json.

@fzipi fzipi merged commit 318a288 into coreruleset:main May 10, 2024
@theseion theseion deleted the bugfix/252-add-missing-json-rule branch May 10, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modsecurity.conf does not create the same config as before
2 participants