Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.toml: Add homepage #835

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Conversation

travier
Copy link
Member

@travier travier commented Feb 5, 2025

Fixes a warning when preparing the release.


Will also serve as a test for the failure in #834

Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, however if we want to switch over to not publishing, that should squash warnings like this.
To do so, use e.g. https://github.com/containers/bootc/blob/5e0df36305cfda93eab0ca70678b618d1f2844f0/cli/Cargo.toml#L8

@travier
Copy link
Member Author

travier commented Feb 5, 2025

I started looking at what it would take us to stop publishing and do our own releases but that's a significant amount of changes and I would prefer to not block the 0.2.27 release on that. Another option is to backport just #790 into Fedora for now.

@travier
Copy link
Member Author

travier commented Feb 5, 2025

Added a commit to temporarily build using Ubuntu-22.04 runners as the builds regularly fails on the 24.04 ones. Made: #836

@@ -7,7 +7,7 @@ permissions:

jobs:
crossarch-check:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean 24.04 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest is now 24.04. This downgrades to 22.04 to make the tests pass. It's similar to build issues that we've seen in other repos: coreos/afterburn#1156

I have not figured out where the failure is exactly.

Maybe we should run this cross-build on the new aarch64 runners as that should be faster as well.

@cgwalters cgwalters merged commit b13dc60 into coreos:main Feb 6, 2025
11 of 12 checks passed
@travier travier deleted the main-cargo-homepage branch February 7, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants