feat: add casbin engine support #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangyang9464
reviewed
Jul 4, 2021
tangyang9464
reviewed
Jul 4, 2021
Signed-off-by: closetool <[email protected]>
|
@hsluoyz @chrisohaver plz review |
|
Sorry - this had escaped my radar until now. Will review when I get a chance. I will say though, that I have been considering breaking all policy engine plugins out into separate repositories, which would work better with Go modules. |
|
Hi @chrisohaver any update? |
|
Thanks for the ping. I have decided to reorganize the firewall plugin code, and split the policy engine plugins out into separate repositories. I'll try to get this done soon. |
yonas
reviewed
Jun 28, 2023
There was a problem hiding this comment.
This repository includes two Policy Engine Plugins:
should be:
This repository includes three Policy Engine Plugins:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: closetool [email protected]
Add casbin policy engine support
Fix: casbin/casbin#828