Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carsten's fixes for ietf-01 #20

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Carsten's fixes for ietf-01 #20

merged 2 commits into from
Dec 19, 2024

Conversation

thomas-fossati
Copy link
Member

@thomas-fossati thomas-fossati commented Dec 18, 2024 •
edited
Loading

Equivalent to 0c1bdd1 (i.e., #19)

(I had to cherry-pick it because I confused git with the document renaming.)

@thomas-fossati
Carsten's fixes for ietf-01
57dac35 
Equivalent to 0c1bdd1

Signed-off-by: Thomas Fossati <[email protected]>
@thomas-fossati thomas-fossati mentioned this pull request Dec 18, 2024
Closed
@thomas-fossati thomas-fossati requested a review from cabo December 18, 2024 17:47
EskoDijk
EskoDijk approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@EskoDijk EskoDijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made one small change DE -> Designated Expert with notes on the why.
This should be ready to merge! Thanks for the improvements.

@thomas-fossati thomas-fossati merged commit c94bbe1 into main Dec 19, 2024
2 checks passed
@thomas-fossati thomas-fossati deleted the cabo-fixes branch December 19, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EskoDijk EskoDijk EskoDijk approved these changes

@cabo cabo Awaiting requested review from cabo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomas-fossati @EskoDijk