CORE-18961 fiber cache per sandbox #5444
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototypes having an instance of a fiber cache tied to a sandbox rather than one fiber cache as a singleton. This means closing a sandbox always results in the removal of the fiber cache for fibers which pertain to that sandbox and they can never be used against the wrong sandbox.
In summary, right now, fibers can be pulled from the singleton fiber cache after the sandbox in which the fiber classes are instantiated was evicted from the cache. Cache eviction listeners don't work as a solution to this in the case where the sequence of events is:
This is not tested at all and there are no unit test changes etc. This PR is for initial feedback on the approach.