move linting and mypy to separate ci jobs

corbado · May 10, 2024 · 38aa735 · 38aa735
1 parent c9a6010
commit 38aa735
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml
@@ -12,7 +12,7 @@ on:
     branches: [ "main" ]
 
 jobs:
-  build:
+  build and test:
 
     runs-on: ubuntu-latest
     strategy:
@@ -32,11 +32,28 @@ jobs:
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip
-        python -m pip install .[test,flake8,tox_gh,tox,mypy]
+        python -m pip install .[test,tox_gh,tox]
     - name: Test with tox
       run: |
         tox run
       env:
         CORBADO_BACKEND_API: ${{ secrets.CORBADO_BACKEND_API }}
         CORBADO_API_SECRET: ${{ secrets.CORBADO_API_SECRET }}
         CORBADO_PROJECT_ID: ${{ secrets.CORBADO_PROJECT_ID }}
+    lint:
+    name: Lint & Mypy
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up Python 3
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.8"
+      - name: Install dependencies
+          run: |
+            python -m pip install --upgrade pip
+            python -m pip install .[mypy,flake8]
+      - name: mypy
+        run: mypy -p corbado_python_sdk --exclude src/corbado_python_sdk/generated/ --strict --disable-error-code attr-defined
+      - name: lint with flake8
+        run: flake8 .
diff --git a/tox.ini b/tox.ini
@@ -13,7 +13,7 @@ python =
     3.11: py311
     3.10: py310
     3.9:  py39
-    3.8: py38,  mypy, flake8
+    3.8:  py38