Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prettify and Lint scripts for each sub-project and top level client #923

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Durbatuluk1701
Copy link
Contributor

Main Highlights:

  1. Yarn scripts for running the prettifier (in-place prettifies files) and linter
  2. Linter made stricter
  3. Typechecker made stricter (no explicit typecasting with as, tries to force exhaustive switch statements, etc.)
     

I think this should hopefully allow for some development quality of life improvements.

One thing I will mention, it feels duplicative (albeit the most expressive) at the moment to have each sub-project carrying its own prettier, linter, and TS config.
Should I explore trying to collapse these into one top level config that applies to the sub-projects as well, or let each sub-project configure itself in case it needs more fine-grained control?

Another question: Should enforcing meeting the style standard (prettier --check .) be a test/requirement checked in CI build?

@Durbatuluk1701
Copy link
Contributor Author

If the new rules and changes seem good, I think I will run yarn run prettify:all and yarn run lint:all, fix any lint issues, then hopefully the whole client dir will be consistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant