Add Prettify and Lint scripts for each sub-project and top level client #923
+2,964
−77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Highlights:
as
, tries to force exhaustive switch statements, etc.)I think this should hopefully allow for some development quality of life improvements.
One thing I will mention, it feels duplicative (albeit the most expressive) at the moment to have each sub-project carrying its own prettier, linter, and TS config.
Should I explore trying to collapse these into one top level config that applies to the sub-projects as well, or let each sub-project configure itself in case it needs more fine-grained control?
Another question: Should enforcing meeting the style standard (
prettier --check .
) be a test/requirement checked in CI build?