-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vine: a manager argument to rename runtime directory #4041
Merged
btovar
merged 8 commits into
cooperative-computing-lab:master
from
JinZhou5042:rename_vine_log
Feb 6, 2025
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f4372b0
add run_info_dir
JinZhou5042 8c84230
vine: rename runtime_info_path to runtime_info_template
JinZhou5042 38427df
vine: check if the template has exists
JinZhou5042 81820a6
lint
JinZhou5042 f3dfb69
set info template with api
btovar a1601f6
update python
btovar c79d7dc
update param name
btovar 9b1ce4f
Merge branch 'cooperative-computing-lab:master' into rename_vine_log
JinZhou5042 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting the template should only modify the value from
"%Y-%m-%dT%H%M%S"
.vine_set_runtime_info_template
should be called inside the other function to actually create the directories.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@btovar Though I was able to create the directories with the desired names, I assume it is because the
vine_set_runtime_info_path
andvine_set_runtime_info_template
are called prior tovine_ssl_create
in the manager's code, so the manager has the right global variables and env variables to initialize?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, we are setting the variables just before the manager creation.