Fix bugs with selectors #1164
Open
Fix bugs with selectors #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 6, 2025 19:59
The old "hack" which injects it into the HTML raw fails on firefox.
…eplaces them with new ones. But this is never refreshed on reload, so only the css remains, while the checkboxes are never replaced.
…he actually inserted elements. I chose to, for the sake of least changes, only add the callback once globally. Moreover, the happy-checkbox selector selects the new fancy checkbox, not the native checkbox like the code assumes. Also swaps the order of operations so any callback bound on the native input which may want to change/check the state of the happy checkbox is in a consistent, new state.
… parry checkboxes can never be kep in sync with the native checkboxes. This necessitated adding a check thet I am not changing the current element. On reload checkbox callbacks were not initialised. Meaning the checkboxes could not do a second action after the first was invoked as it reloads the page and prevents checking. All callbacks should only ever invoke the onChange on the native input as the happy inputs may not even exist. This prevents inifinite looping. The counter should be initialised to 0/10 so the select count does not just appear out of nowhere. The counter used to show the Total including the check all button if any button but the check all button was clicked. Actually initialise the group action state at all times. Any javascript could run before this callback and this would ignore the checked boxes. The multirow selection did ot work due to 1) no change events 2) the last checkbox being change at the start of the function rather than the end. 3) we were taking the lastCheckbox and lastCheckbox??? 4) rowindex is global not only in this part of the table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the happy.ts and checkboxes.ts had many bugs.
...