This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
Added React Modal component to the UI Component Library #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added a Modal component that supports stacking. console.log are left intentionally for reviewer to look into thought process
…ement, so only a few specific HTML elements can be selected using the Tab key. Handles backdrop with a simple fade animation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Create a reusable Modal using React to be used by other engineers in the Contra platform, in a reusable manner.
Solution:
Using the native
dialogHTML element, adding some React flair on top achieve some additional features, such as backdrop dismissing, tab management and trapping focus when it's a Non-Modal.Please don't forget to read a little bit about my Technical Writing: frontend/src/components/Dialog/README.md
My recorded loom: https://www.loom.com/share/bb5dcd96b5bf4c6abe89e5408d0640c3
Demo usage: https://www.loom.com/share/2935b9653e704dc89f5017b050fae2a1