Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for GitHub Actions #62

Merged
merged 10 commits into from
Aug 14, 2024
Merged

feat: add support for GitHub Actions #62

merged 10 commits into from
Aug 14, 2024

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Jul 2, 2024

Power by OIDC exclusively instead of using log based proof. OIDC is the Cool Thing that didn't exist when CFA was originally written, relying on it for the GHA implementation makes sense.

There are two other refactors included in this PR:

  • Getting a github token from the CFA app now requires a permission dict indicating permissions you want the token to have. This is done as the app now has more permissions than it needs and we don't want to give those permissions to the token we give the client
  • The OIDC validation logic is now extracted to a generic helper to allow us to re-use it for validating a github actions OIDC token

Closes #3

Power by OIDC exclusively instead of using log based proof. OIDC is the Cool Thing that didn't exist when CFA was originally written, relying on it for the GHA implementation makes sense.
@MarshallOfSound MarshallOfSound requested review from a team as code owners August 7, 2024 23:09
@MarshallOfSound MarshallOfSound temporarily deployed to continuous-auth-production August 12, 2024 21:03 Inactive
@MarshallOfSound MarshallOfSound temporarily deployed to continuous-auth-production August 12, 2024 22:01 Inactive
@MarshallOfSound MarshallOfSound temporarily deployed to continuous-auth-production August 12, 2024 22:05 Inactive
@MarshallOfSound MarshallOfSound temporarily deployed to continuous-auth-production August 12, 2024 22:08 Inactive
@MarshallOfSound MarshallOfSound temporarily deployed to continuous-auth-production August 12, 2024 22:35 Inactive
@MarshallOfSound MarshallOfSound merged commit 63893af into main Aug 14, 2024
2 checks passed
@MarshallOfSound MarshallOfSound deleted the gha branch August 14, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] GitHub Actions support?
2 participants